fix: Properly load and restore the metadata for saves (#1550)

* fix: save metadata loading

Notify others that the thumbnail data is loaded.

Refs: #124

* refactor: remove redundant class field

COMPILE.md

@@ -2,13 +2,14 @@
 
 ## Visual Studio
 
-1. Clone or download the repository
-1. Open the repo folder in Visual Studio 2022+.
-2. Wait for cmake to configure the project and load all assets (this may take a few minutes on the first run).
-3. Right click a folder in the solution explorer and switch to the 'CMake Targets View'
-4. Select platform and configuration from the dropdown. EG: `Windows64 - Debug` or `Windows64 - Release`
-5. Pick the startup project `Minecraft.Client.exe` or `Minecraft.Server.exe` using the debug targets dropdown
-6. Build and run the project:
+1. Clone the repo, including submodules.
+    - If you don't, the build will fail. `git clone --recurse-submodules https://github.com/MCLCE/MinecraftConsoles.git`
+2. Open the repo folder in Visual Studio 2022+.
+3. Wait for cmake to configure the project and load all assets (this may take a few minutes on the first run).
+4. Right click a folder in the solution explorer and switch to the 'CMake Targets View'
+5. Select platform and configuration from the dropdown. EG: `Windows64 - Debug` or `Windows64 - Release`
+6. Pick the startup project `Minecraft.Client.exe` or `Minecraft.Server.exe` using the debug targets dropdown
+7. Build and run the project:
    - `Build > Build Solution` (or `Ctrl+Shift+B`)
    - Start debugging with `F5`.
 

Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp

@@ -53,7 +53,6 @@ int UIScene_LoadMenu::LoadSaveDataThumbnailReturned(LPVOID lpParam,PBYTE pbThumb
 			app.DebugPrintf("Thumbnail data is nullptr, or has size 0\n");
 			pClass->m_bThumbnailGetFailed = true;
 		}
-		pClass->m_bRetrievingSaveThumbnail = false;
 	}
 
 	return 0;
@@ -100,7 +99,6 @@ UIScene_LoadMenu::UIScene_LoadMenu(int iPad, void *initData, UILayer *parentLaye
 	m_bIsSaveOwner = true;
 
 	m_bSaveThumbnailReady = false;
-	m_bRetrievingSaveThumbnail = true;
 	m_bShowTimer = false;
 	m_pDLCPack = nullptr;
 	m_bAvailableTexturePacksChecked=false;
@@ -274,9 +272,9 @@ UIScene_LoadMenu::UIScene_LoadMenu(int iPad, void *initData, UILayer *parentLaye
 				m_bitmapIcon.setTextureName(wFilename);
 				m_pbThumbnailData = params->saveDetails->pbThumbnailData;
 				m_uiThumbnailSize = params->saveDetails->dwThumbnailSize;
+				m_bSaveThumbnailReady = true;
 			}
 
-			m_bRetrievingSaveThumbnail = false;
 		}
 #endif
 	}

Minecraft.Client/Common/UI/UIScene_LoadMenu.h

@@ -50,7 +50,6 @@ private:
 	int m_iGameModeId;
 	bool m_bHasBeenInCreative;
 	bool m_bIsSaveOwner;
-	bool m_bRetrievingSaveThumbnail;
 	bool m_bSaveThumbnailReady;
 	bool m_bMultiplayerAllowed;
 	bool m_bShowTimer;