yuanzhe1999/windows95
1
0
Fork 0
mirror of https://github.com/felixrieseberg/windows95.git synced 2026-05-09 00:24:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove hardcoded TEMP path; expand deb maker diagnostic

Browse Source 
The TEMP override in forge.config.js broke Windows builds on CI runners (mkdtemp ENOENT). The expanded diagnostic exercises require() from maker-base's own resolution context to surface the real Linux failure.
This commit is contained in:
Felix Rieseberg
2026-04-12 14:23:55 -07:00
parent bbcc4f32cd
commit e1c30f701c
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/build.yml vendored
View File

@@ -81,7 +81,11 @@ jobs:
run: npm ci run: npm ci
- name: Diagnose deb maker - name: Diagnose deb maker
if: matrix.os == 'ubuntu-latest' if: matrix.os == 'ubuntu-latest'
run: node -e "try{require('electron-installer-debian');console.log('deb installer OK')}catch(e){console.error(e)}" run: |
node -e "const r=require('module').createRequire(require.resolve('@electron-forge/maker-base/package.json'));try{r('electron-installer-debian');console.log('OK from maker-base')}catch(e){console.error('FAIL from maker-base:',e)}"
node -e "const {MakerDeb}=require('@electron-forge/maker-deb');const m=new MakerDeb({});console.log('isSupported:',m.isSupportedOnCurrentPlatform());try{m.ensureExternalBinariesExist();console.log('binaries OK')}catch(e){console.error('binaries:',e.message)}"
ls -la node_modules/electron-installer-debian/ || echo "NOT INSTALLED"
which dpkg fakeroot || echo "missing binaries"
- name: Make - name: Make
if: startsWith(github.ref, 'refs/tags/') if: startsWith(github.ref, 'refs/tags/')
run: npm run make -- --arch=${{ matrix.arch }} run: npm run make -- --arch=${{ matrix.arch }}

2
forge.config.js
View File

@@ -4,8 +4,6 @@ const package = require('./package.json');
require('dotenv').config() require('dotenv').config()
process.env.TEMP = process.env.TMP = `C:\\Users\\FelixRieseberg\\AppData\\Local\\Temp`
const FLAGS = { const FLAGS = {
SIGNTOOL_PATH: process.env.SIGNTOOL_PATH, SIGNTOOL_PATH: process.env.SIGNTOOL_PATH,
AZURE_CODE_SIGNING_DLIB: process.env.AZURE_CODE_SIGNING_DLIB || path.join(__dirname, 'Microsoft.Trusted.Signing.Client.1.0.60/bin/x64/Azure.CodeSigning.Dlib.dll'), AZURE_CODE_SIGNING_DLIB: process.env.AZURE_CODE_SIGNING_DLIB || path.join(__dirname, 'Microsoft.Trusted.Signing.Client.1.0.60/bin/x64/Azure.CodeSigning.Dlib.dll'),